Attention is currently required from: fixeria.
Patch set 1:Code-Review +2
View Change
2 comments:
File src/osmux.c:
Patch Set #1, Line 470: !state.rtph
Why are you changing this? I guess because below in your code you're doing !foo. […]
I just really rewrote the whole code several times before finding the best way, so it ended up this way.
Patch Set #1, Line 535: struct amr_hdr *amrh
const?
I'll do a full pass of constifying everything possible in a follow up patch, I bet several things can be marked as const.
To view, visit change 29512. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I25eb6ee54c898f575cc71ccfd6d190fe51d56dbe
Gerrit-Change-Number: 29512
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Reviewer: laforge <laforge@osmocom.org>
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Sep 2022 09:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>
Gerrit-MessageType: comment