Attention is currently required from: wbokslag. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-tetra/+/29387 ) Change subject: added support for fill bits and basic link defragmentation (also thanks to SQ5BPF) ...................................................................... Patch Set 1: Code-Review-1 (6 comments) File src/tetra_llc_pdu.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/4e9c20e6_86624c56 PS1, Line 80: unrelated ws changed File src/tetra_mac_pdu.h: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/bcfe051a_f99de347 PS1, Line 160: unrelated ws change File src/tetra_mac_pdu.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/32eca4db_e3c142cb PS1, Line 64: In this particular place, it's a good change. But it should be done in a separate patch. https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/877cd340_dd50c049 PS1, Line 97: cad->type = bits_to_uint(cur, 2); cur += 2; Please keep the original formatting in this patch. Unrelated changes make it harder to see what's actually done during code review (and probably later). https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/ec5bc71b_677ea78b PS1, Line 387: why are you changing this? maybe it's your editor doing this automatically? File src/tetra_upper_mac.c: https://gerrit.osmocom.org/c/osmo-tetra/+/29387/comment/d9f119f8_845d348f PS1, Line 51: msgb_reset I don't think calling msgb_reset() is needed right after calling msgb_alloc(). It's already reset when allocated. Correct me if I am wrong. -- To view, visit https://gerrit.osmocom.org/c/osmo-tetra/+/29387 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-tetra Gerrit-Branch: master Gerrit-Change-Id: I41c9438b0b12c2fac9dff1b226eec5b33f30fbb4 Gerrit-Change-Number: 29387 Gerrit-PatchSet: 1 Gerrit-Owner: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de> Gerrit-Attention: wbokslag <w.bokslag(a)midnightblue.nl> Gerrit-Comment-Date: Sun, 18 Sep 2022 13:07:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment