Attention is currently required from: wbokslag.
Patch set 1:Code-Review -1
6 comments:
File src/tetra_llc_pdu.h:
unrelated ws changed
File src/tetra_mac_pdu.h:
unrelated ws change
File src/tetra_mac_pdu.c:
In this particular place, it's a good change. But it should be done in a separate patch.
Patch Set #1, Line 97: cad->type = bits_to_uint(cur, 2); cur += 2;
Please keep the original formatting in this patch. Unrelated changes make it harder to see what's actually done during code review (and probably later).
why are you changing this?
maybe it's your editor doing this automatically?
File src/tetra_upper_mac.c:
Patch Set #1, Line 51: msgb_reset
I don't think calling msgb_reset() is needed right after calling msgb_alloc(). It's already reset when allocated. Correct me if I am wrong.
To view, visit change 29387. To unsubscribe, or for help writing mail filters, visit settings.