Attention is currently required from: iedemam, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/27081 )
Change subject: WIP: New stats for lchan life duration. ......................................................................
Patch Set 4:
(3 comments)
File src/osmo-bsc/bts_trx_vty.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/a11f1499_4bd36483 PS4, Line 575: vty_out(vty, " Activated %llu ms ago%s", duration_ms, VTY_NEWLINE);
Probably more interesting to print it in VTY as seconds? Doesn't look like we can glance millisecond […]
Ack
File src/osmo-bsc/gsm_data.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/46898db0_b4de1db2 PS4, Line 349: long long wondering if a signed data type makes sense here, but this is not critical.
File src/osmo-bsc/lchan_fsm.c:
https://gerrit.osmocom.org/c/osmo-bsc/+/27081/comment/ce2f4e08_3501ff19 PS4, Line 1816: rate_ctr_add(rate_ctr_group_get_ctr(bts_ctrs, BTS_CTR_LCHAN_TCH_TOTAL_ACTIVE_MILLISECONDS), duration_ms);
Does it really makes sense to use this kind of value as a rate_ctr? Just asking. […]
my gut feeling also goes more towards a stat_item, but I didn't spend a lot of time contemplating it.
-
laforge