Attention is currently required from: iedemam, neels, pespin.

View Change

3 comments:

• File src/osmo-bsc/bts_trx_vty.c:

  • Patch Set #4, Line 575: vty_out(vty, " Activated %llu ms ago%s", duration_ms, VTY_NEWLINE);

    Probably more interesting to print it in VTY as seconds? Doesn't look like we can glance millisecond […]

    Ack

• File src/osmo-bsc/gsm_data.c:

  • Patch Set #4, Line 349: long long

    wondering if a signed data type makes sense here, but this is not critical.

• File src/osmo-bsc/lchan_fsm.c:

  • Patch Set #4, Line 1816: rate_ctr_add(rate_ctr_group_get_ctr(bts_ctrs, BTS_CTR_LCHAN_TCH_TOTAL_ACTIVE_MILLISECONDS), duration_ms);

    Does it really makes sense to use this kind of value as a rate_ctr? Just asking. […]

    my gut feeling also goes more towards a stat_item, but I didn't spend a lot of time contemplating it.

To view, visit change 27081. To unsubscribe, or for help writing mail filters, visit settings.