Attention is currently required from: dexter, laforge, pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214?usp=email )

Change subject: invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318 ......................................................................

Patch Set 12:

(5 comments)

File include/osmocom/mgcp/mgcp_common.h:

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/e4bc32f5_1ada386d PS10, Line 71: enum mgcp_gsm_hr_fmt gsm_hr_format;

Ok, then we will have to clean up this problem first. I am having a look at this. […]

Done

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/40b8e102_2ec1e8af PS10, Line 705: case GSM_HR_BYTES + sizeof(struct rtp_hdr):

if possible order the fields left to right based on the order you encounter them in the pkt.

it's in a prior patch but i agree

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/83fa19be_acbb8c64 PS10, Line 741: bool convert = false;

can be dropped.

nope

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/1f4767de_5c28ae1d PS10, Line 746: convert = true;

return true;

nope, still need to compare whether this is GSM-HR below, note 'convert && ...'

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/f82b5453_e8c3624c PS10, Line 750: convert = true;

return true;

Done