Attention is currently required from: dexter, laforge, pespin.

View Change

5 comments:

• File include/osmocom/mgcp/mgcp_common.h:

  • Patch Set #10, Line 71: enum mgcp_gsm_hr_fmt gsm_hr_format;

    Ok, then we will have to clean up this problem first. I am having a look at this. […]

    Done

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #10, Line 705: case GSM_HR_BYTES + sizeof(struct rtp_hdr):

    if possible order the fields left to right based on the order you encounter them in the pkt.

    it's in a prior patch but i agree

  • Patch Set #10, Line 741: bool convert = false;

    can be dropped.

    nope

  • Patch Set #10, Line 746: convert = true;

    return true;

    nope, still need to compare whether this is GSM-HR below, note 'convert && ...'

  • Patch Set #10, Line 750: convert = true;

    return true;

    Done

To view, visit change 31214. To unsubscribe, or for help writing mail filters, visit settings.