Attention is currently required from: pespin.

falconia has posted comments on this change by falconia. ( https://gerrit.osmocom.org/c/osmo-bts/+/42166?usp=email )

Change subject: RTP: use new abstraction layer instead of direct osmo_ortp ......................................................................

Patch Set 2:

(3 comments)

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/590d9c83_6f510fb2?usp=... : PS2, Line 2329: lchan_osmux_skipped_frame(lchan, fn_ms_adj(fn, lchan));

fn_ms_adj is also called here, so feel free to put fn_ms_adj above and modify this function too sinc […]

Will do in the next patch revision. For consistency, I will also make the same change in `send_ul_rtp_packet()`.

File src/common/lchan.c:

https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/12657874_2662996f?usp=... : PS2, Line 590: false, bts->twjit_cfg);

align to "(", like done eveyrwhere else.

Will do.

https://gerrit.osmocom.org/c/osmo-bts/+/42166/comment/84ecec2b_18be186b?usp=... : PS2, Line 641: ia, connect_port);

ah so osmo_rtp_socket_connect() actually got a string, and you are converting now this param into an […]

I would like to push back against making this change as part of the present patch - instead it should be done after ortp is fully removed and we are ready to begin the process of IPv6-ifying twrtp-based OsmoBTS. See my comment in the IPv6 thread on the previous patch in the series.