Attention is currently required from: pespin.

View Change

3 comments:

• File src/common/l1sap.c:

  • Patch Set #2, Line 2329: lchan_osmux_skipped_frame(lchan, fn_ms_adj(fn, lchan));

    fn_ms_adj is also called here, so feel free to put fn_ms_adj above and modify this function too sinc […]

    Will do in the next patch revision. For consistency, I will also make the same change in `send_ul_rtp_packet()`.

• File src/common/lchan.c:

  • Patch Set #2, Line 590: false, bts->twjit_cfg);

    align to "(", like done eveyrwhere else.

    Will do.

  • Patch Set #2, Line 641: ia, connect_port);

    ah so osmo_rtp_socket_connect() actually got a string, and you are converting now this param into an […]

    I would like to push back against making this change as part of the present patch - instead it should be done after ortp is fully removed and we are ready to begin the process of IPv6-ifying twrtp-based OsmoBTS. See my comment in the IPv6 thread on the previous patch in the series.

To view, visit change 42166. To unsubscribe, or for help writing mail filters, visit settings.