Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-gprs/+/30490 )

Change subject: sndcp: Initial libosmo-gprs-sndcp support ......................................................................

Patch Set 12: Code-Review-1

(5 comments)

File include/osmocom/gprs/sndcp/sndcp.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/faa04f12_8862d943 PS12, Line 8: osmocom/core/msgb.h You're not using msgb API in this file, why including it here?

https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/a711d9cf_f7b8ed3b PS12, Line 13: GPRS_ missing OSMO_ prefix in public API

File include/osmocom/gprs/sndcp/sndcp_prim.h:

https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/1c613d94_56746455 PS12, Line 117: OSMO_GPRS_SNDCP_BSSGP_ OSMO_GPRS_SNDCP_SNSM_

File tests/sndcp/Makefile.am:

https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/df0dd715_afe7bd72 PS12, Line 53: $(NULL) " No newline at end of revision file. "

File tests/testsuite.at:

https://gerrit.osmocom.org/c/libosmo-gprs/+/30490/comment/f2a9aeb4_d0bc99d8 PS12, Line 56: AT_CLEANUP " No newline at end of revision file. "