Attention is currently required from: pespin.

Patch set 12:Code-Review -1

View Change

5 comments:

• File include/osmocom/gprs/sndcp/sndcp.h:

  • Patch Set #12, Line 8: osmocom/core/msgb.h

    You're not using msgb API in this file, why including it here?

  • Patch Set #12, Line 13: GPRS_

    missing OSMO_ prefix in public API

• File include/osmocom/gprs/sndcp/sndcp_prim.h:

  • Patch Set #12, Line 117: OSMO_GPRS_SNDCP_BSSGP_

    OSMO_GPRS_SNDCP_SNSM_

• File tests/sndcp/Makefile.am:

  • Patch Set #12, Line 53: $(NULL)

    " No newline at end of revision file. "

• File tests/testsuite.at:

  • Patch Set #12, Line 56: AT_CLEANUP

    " No newline at end of revision file. "

To view, visit change 30490. To unsubscribe, or for help writing mail filters, visit settings.