Attention is currently required from: dexter, laforge, pespin.

neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/31214?usp=email )

Change subject: invent fmtp 'gsm-hr-format', for RFC5993 vs 3GPP TS 101.318 ......................................................................

Patch Set 13: Code-Review-1

(2 comments)

Patchset:

PS13: i found this aspect but am out of time for now. next up i want to check what the code actually does.

File src/libosmo-mgcp/mgcp_network.c:

https://gerrit.osmocom.org/c/osmo-mgw/+/31214/comment/541b9754_088efb3b PS13, Line 692: explicitly specified the target format will be the opposite of the input : * format. this makes no sense to me.

If a target has specified a format, we can convert to it the specified format.

But if a target has not specified a format, we cannot let the source dictate which format we send to the target. Obviously we should not switch target encoding because the source side has modified its payload type.