Attention is currently required from: dexter, laforge, pespin.

Patch set 13:Code-Review -1

View Change

2 comments:

• Patchset:

  • Patch Set #13:

    i found this aspect but am out of time for now.
    next up i want to check what the code actually does.

• File src/libosmo-mgcp/mgcp_network.c:

  • Patch Set #13, Line 692:

    explicitly specified the target format will be the opposite of the input
     * format.
    

    this makes no sense to me.

    If a target has specified a format, we can convert to it the specified format.

    But if a target has not specified a format, we cannot let the source dictate which format we send to the target. Obviously we should not switch target encoding because the source side has modified its payload type.

To view, visit change 31214. To unsubscribe, or for help writing mail filters, visit settings.