Attention is currently required from: Timur Davydov, fixeria, pespin.
osmith has posted comments on this change by Timur Davydov. ( https://gerrit.osmocom.org/c/libosmocore/+/41922?usp=email )
Change subject: core: guard TCP stats on availability of linux/tcp.h ......................................................................
Patch Set 3: Code-Review+2
(3 comments)
File src/core/stats_tcp.c:
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/8e40e681_1c7c9d60?u... : PS1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0);
Done. I reworked it as suggested: the implementation is now wrapped in […]
Done
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/8cf23948_81545932?u... : PS1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL);
Done. I reworked it as suggested: the implementation is now wrapped in […]
Done
File src/core/stats_tcp.c:
https://gerrit.osmocom.org/c/libosmocore/+/41922/comment/3086d411_a014370b?u... : PS2, Line 47: #include <errno.h>
Done, moved it above the HAVE_LINUX_TCP_H guard.
Done, marking as resolved (there is a checkbox for resolving threads, so future reviewers don't need to read through them as well).
-
osmith