Attention is currently required from: Timur Davydov, fixeria, pespin.

Patch set 3:Code-Review +2

View Change

3 comments:

• File src/core/stats_tcp.c:

  • Patch Set #1, Line 315: osmo_timer_schedule(&stats_tcp_poll_timer, osmo_tcp_stats_config->interval, 0);

    Done. I reworked it as suggested: the implementation is now wrapped in […]

    Done

  • Patch Set #1, Line 328: osmo_timer_setup(&stats_tcp_poll_timer, stats_tcp_poll_timer_cb, NULL);

    Done. I reworked it as suggested: the implementation is now wrapped in […]

    Done

• File src/core/stats_tcp.c:

  • Patch Set #2, Line 47: #include <errno.h>

    Done, moved it above the HAVE_LINUX_TCP_H guard.

    Done, marking as resolved (there is a checkbox for resolving threads, so future reviewers don't need to read through them as well).

To view, visit change 41922. To unsubscribe, or for help writing mail filters, visit settings.