Attention is currently required from: jolly. pespin has posted comments on this change by jolly. ( https://gerrit.osmocom.org/c/libosmocore/+/40584?usp=email ) Change subject: osmo-io: Append received message to pending message segment ...................................................................... Patch Set 1: Code-Review-1 (2 comments) Commit Message: https://gerrit.osmocom.org/c/libosmocore/+/40584/comment/035600be_08802272?… : PS1, Line 9: If there is pending data of an incomplete segmented message, received Would you mind rewriting this? The way it is written makes it not really clear what the previous state was, what the patch changes, etc. Specially since you say some stuff will be done in a later patch. So I'm not sure if you are breaking previously working stuff or what. File src/core/osmo_io.c: https://gerrit.osmocom.org/c/libosmocore/+/40584/comment/436bb2b9_175cb01d?… : PS1, Line 303: msg_pending = iofd_msgb_alloc2(iofd, extra_len); afaiu this is wrong. You are confusing the received_len with the size of the msgb. What you'd want to pass here is, in the event that "expected_len > iofd->msgb_alloc.size" (which shouldn't happen imho, and in that case it would be a bug of the user of osmo_iodf when configuring it based on protocol expectancies): iofd_msgb_alloc2(iofd, expected_len - iofd->msgb_alloc.size); In any case, this would also break the assumption on the user that the msgbs obtained are of a certain configured length. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/40584?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I08df9736ccc5e9a7df61ca6dcf94629ee010752f Gerrit-Change-Number: 40584 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andreas(a)eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin(a)sysmocom.de> Gerrit-Attention: jolly <andreas(a)eversberg.eu> Gerrit-Comment-Date: Fri, 04 Jul 2025 13:45:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes