Attention is currently required from: jolly.

Patch set 1:Code-Review -1

View Change

2 comments:

• Commit Message:

  • Patch Set #1, Line 9: If there is pending data of an incomplete segmented message, received

    Would you mind rewriting this?
    The way it is written makes it not really clear what the previous state was, what the patch changes, etc.

    Specially since you say some stuff will be done in a later patch. So I'm not sure if you are breaking previously working stuff or what.

• File src/core/osmo_io.c:

  • Patch Set #1, Line 303: msg_pending = iofd_msgb_alloc2(iofd, extra_len);

    afaiu this is wrong. You are confusing the received_len with the size of the msgb.

    What you'd want to pass here is, in the event that "expected_len > iofd->msgb_alloc.size" (which shouldn't happen imho, and in that case it would be a bug of the user of osmo_iodf when configuring it based on protocol expectancies):

    iofd_msgb_alloc2(iofd, expected_len - iofd->msgb_alloc.size);

    In any case, this would also break the assumption on the user that the msgbs obtained are of a certain configured length.

To view, visit change 40584. To unsubscribe, or for help writing mail filters, visit settings.