Attention is currently required from: pespin.
arehbein has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/32354 )
Change subject: gsm_objclass2obj(): Change signature so we can obtain a nack cause in case
of error
......................................................................
Patch Set 1:
(2 comments)
File src/common/oml.c:
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/9c46adb3_957f77e3
PS1, Line 1799: gsm_objclass2obj(enum abis_nm_nack_cause *c, struct gsm_bts *bts, uint8_t
obj_class,
same here, this should be at the end and be able to
pass NULL to it.
Done
https://gerrit.osmocom.org/c/osmo-bts/+/32354/comment/072b13d5_49b3ede2
PS1, Line 1804: /* Handle finding TRX number first */
Same here, please don't move this into a new
switch.
Done
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/32354
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If734ea2c8cae4c1f99b02520dffa4e3862a67745
Gerrit-Change-Number: 32354
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: pespin <pespin(a)sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Apr 2023 23:00:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin(a)sysmocom.de>
Gerrit-MessageType: comment