Attention is currently required from: pespin.
View Change
2 comments:
File src/common/oml.c:
Patch Set #1, Line 1799: gsm_objclass2obj(enum abis_nm_nack_cause *c, struct gsm_bts *bts, uint8_t obj_class,
same here, this should be at the end and be able to pass NULL to it.
Done
Patch Set #1, Line 1804: /* Handle finding TRX number first */
Same here, please don't move this into a new switch.
Done
To view, visit change 32354. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: If734ea2c8cae4c1f99b02520dffa4e3862a67745
Gerrit-Change-Number: 32354
Gerrit-PatchSet: 1
Gerrit-Owner: arehbein <arehbein@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pespin@sysmocom.de>
Gerrit-Attention: pespin <pespin@sysmocom.de>
Gerrit-Comment-Date: Tue, 18 Apr 2023 23:00:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pespin@sysmocom.de>
Gerrit-MessageType: comment