Attention is currently required from: dexter.

pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34058 )

Change subject: pcu_l1_if: add support for PCU_IF_SAPI_AGCH_2 for PCUIF v.11 ......................................................................

Patch Set 2: Code-Review-1

(4 comments)

File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/37f87897_604e4566 PS2, Line 1037: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false); if we don't need cofnirmation so far, we don't need to pass a msg_id based on TLLI which may be actually TLLI_UNUSED sometimes. Hence, I think for not it's better to pass TLLI_UNUSED always here.

https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/36465058_67a5f519 PS2, Line 1055: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false); Same, TLLI_UNUSED

File src/pcu_l1_if.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/1c5f882d_e7e3a6e7 PS2, Line 150: void pcu_l1if_tx_agch2(struct gprs_rlcmac_bts *bts, bitvec *block, int plen, bool conform, uint32_t msg_id); typo: confirm

File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/3300277c_f63cd3da PS2, Line 278: /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX why did you drop this comment? This all still holds true afaict if v10 is being used.