Attention is currently required from: dexter.

Patch set 2:Code-Review -1

View Change

4 comments:

• File src/bts.cpp:

  • Patch Set #2, Line 1037: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false);

    if we don't need cofnirmation so far, we don't need to pass a msg_id based on TLLI which may be actually TLLI_UNUSED sometimes. Hence, I think for not it's better to pass TLLI_UNUSED always here.

  • Patch Set #2, Line 1055: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false);

    Same, TLLI_UNUSED

• File src/pcu_l1_if.h:

  • Patch Set #2, Line 150: void pcu_l1if_tx_agch2(struct gprs_rlcmac_bts *bts, bitvec *block, int plen, bool conform, uint32_t msg_id);

    typo: confirm

• File src/pcu_l1_if.cpp:

  • Patch Set #2, Line 278: /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX

    why did you drop this comment? This all still holds true afaict if v10 is being used.

To view, visit change 34058. To unsubscribe, or for help writing mail filters, visit settings.