Attention is currently required from: laforge.
fixeria has posted comments on this change. (
https://gerrit.osmocom.org/c/pysim/+/31056
)
Change subject: gsm_r: EF_Predefined: Decode first record different from others
......................................................................
Patch Set 3:
(3 comments)
File pySim/gsm_r.py:
https://gerrit.osmocom.org/c/pysim/+/31056/comment/f718b69d_a519bd4f
PS2, Line 254: EF_Predefined
self
Done
https://gerrit.osmocom.org/c/pysim/+/31056/comment/f4d0066e_5170ac03
PS2, Line 257: r = None
In Python (unlike C/C++), if/for/with statements do
not have their own scope.
... so that there is no need to declare r outside of the if.
https://gerrit.osmocom.org/c/pysim/+/31056/comment/8b48f75f_131cfca4
PS2, Line 259: EF_Predefined
self
Done
--
To view, visit
https://gerrit.osmocom.org/c/pysim/+/31056
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: Ib526f6c3c2ac9a945b8242e2e54536628376efc0
Gerrit-Change-Number: 31056
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Comment-Date: Fri, 27 Jan 2023 22:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <laforge(a)osmocom.org>
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment