Attention is currently required from: fixeria, pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34647?usp=email )

Change subject: pcu_l1_if: signal BTS model via PCUIF ......................................................................

Patch Set 2:

(3 comments)

File include/osmocom/pcu/pcuif_proto.h:

https://gerrit.osmocom.org/c/osmo-pcu/+/34647/comment/9793fb22_add9ce4b PS1, Line 70: #define PCU_IF_BTS_MODEL_UNSPEC 0x00

I definetly want an enum here. The field in the struct can remain a uint of known size.

Done

https://gerrit.osmocom.org/c/osmo-pcu/+/34647/comment/07bbd891_48eb8b60 PS1, Line 193: uint8_t bts_model;

comment referencing the enum type above.

Done

File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34647/comment/ead06207_58fcb40a PS1, Line 1016: LOGP(DL1IF, LOGL_INFO, "BTS model: %02x\n", info_ind->bts_model);

value_string.

Done