Attention is currently required from: fixeria, pespin.

View Change

3 comments:

• File include/osmocom/pcu/pcuif_proto.h:

  • Patch Set #1, Line 70: #define PCU_IF_BTS_MODEL_UNSPEC 0x00

    I definetly want an enum here. The field in the struct can remain a uint of known size.

    Done

  • Patch Set #1, Line 193: uint8_t bts_model;

    comment referencing the enum type above.

    Done

• File src/pcu_l1_if.cpp:

  • Patch Set #1, Line 1016: LOGP(DL1IF, LOGL_INFO, "BTS model: %02x\n", info_ind->bts_model);

    value_string.

    Done

To view, visit change 34647. To unsubscribe, or for help writing mail filters, visit settings.