Attention is currently required from: pespin.

jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35391?usp=email )

Change subject: Add LLC and HLC transcoding to MNCC transcoding functions ......................................................................

Patch Set 1:

(3 comments)

File include/osmocom/gsm/gsm48_ie.h:

https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/b6766107_5b40f5c3 PS1, Line 39: /* decode 'high layer complatibility' */

"compatibility" in all lines.

Done

File include/osmocom/gsm/mncc.h:

https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/827ec537_14b5c33b PS1, Line 35: struct gsm_mncc_lowl_compat {

some spec reference on what is this about would be nice.

Done

File src/gsm/gsm48_ie.c:

https://gerrit.osmocom.org/c/libosmocore/+/35391/comment/a2d46645_a6a3c850 PS1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */

AFAIU this is all really a len and a buffer, so I don't really see the need for a specific structure […]

You are right, I simplified the functions by removing the 'local buffer'.

I want to have a structure that provides information of content, length and maximum size. Using just a pointer would require an extra length field in the MNCC message for both LLC and HLC. Parsed values can be added to the structure in the future.