Attention is currently required from: pespin.

View Change

3 comments:

• File include/osmocom/gsm/gsm48_ie.h:

  • Patch Set #1, Line 39: /* decode 'high layer complatibility' */

    "compatibility" in all lines.

    Done

• File include/osmocom/gsm/mncc.h:

  • Patch Set #1, Line 35: struct gsm_mncc_lowl_compat {

    some spec reference on what is this about would be nice.

    Done

• File src/gsm/gsm48_ie.c:

  • Patch Set #1, Line 412: /*! Encode TS 04.08 High Layer compatibility IE (10.5.4.16) */

    AFAIU this is all really a len and a buffer, so I don't really see the need for a specific structure […]

    You are right, I simplified the functions by removing the 'local buffer'.

    I want to have a structure that provides information of content, length and maximum size. Using just a pointer would require an extra length field in the MNCC message for both LLC and HLC. Parsed values can be added to the structure in the future.

To view, visit change 35391. To unsubscribe, or for help writing mail filters, visit settings.