Attention is currently required from: iedemam, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/28165 )

Change subject: stats: new trackers for lchan life duration (v2) ......................................................................

Patch Set 3:

(2 comments)

File src/osmo-bsc/lchan_fsm.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/10d914da_7e9ea4c8 PS3, Line 205: lchan->activate.concluded = true; concluded is set to true here at the same time that active_stored is set below, so I don't see how the last change really changes the logic :/

Maybe lchan->activate.concluded is set in another code path? Then that means lchan->active_stored won't be set to something different than 0,0 ever and they will never be counted.

https://gerrit.osmocom.org/c/osmo-bsc/+/28165/comment/b614aed5_8539e30e PS3, Line 519: .active_start = { .tv_sec = 0, .tv_nsec = 0 }, That's not needed, it will be erased by default.