Attention is currently required from: iedemam, neels.

View Change

2 comments:

• File src/osmo-bsc/lchan_fsm.c:

  • Patch Set #3, Line 205: lchan->activate.concluded = true;

    concluded is set to true here at the same time that active_stored is set below, so I don't see how the last change really changes the logic :/

    Maybe lchan->activate.concluded is set in another code path? Then that means lchan->active_stored won't be set to something different than 0,0 ever and they will never be counted.

  • Patch Set #3, Line 519: .active_start = { .tv_sec = 0, .tv_nsec = 0 },

    That's not needed, it will be erased by default.

To view, visit change 28165. To unsubscribe, or for help writing mail filters, visit settings.