Attention is currently required from: pespin.
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 )
Change subject: GTP_Templates: Fix several template type incongruencies ......................................................................
Patch Set 1:
(3 comments)
File library/GTP_Templates.ttcn:
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/8caeb75e_93a13... PS1, Line 285: lengthf := 2 As I said in the IRC, hard-coding `lengthf` to 2 is wrong. It's only valid if `ip_addr` is `omit`, and would not match otherwise. I suggest to use `f_eua_ipv4_len()` here and drop `tr_EuaIPv4`.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/933c7df9_b28ea... PS1, Line 306: lengthf := 2, Same here.
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/f4fd442f_72d7a... PS1, Line 328: lengthf := 2, Same here.