Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 ) Change subject: GTP_Templates: Fix several template type incongruencies ...................................................................... Patch Set 1: (3 comments) File library/GTP_Templates.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/8caeb75e_93a13... PS1, Line 285: lengthf := 2 As I said in the IRC, hard-coding `lengthf` to 2 is wrong. It's only valid if `ip_addr` is `omit`, and would not match otherwise. I suggest to use `f_eua_ipv4_len()` here and drop `tr_EuaIPv4`. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/933c7df9_b28ea... PS1, Line 306: lengthf := 2, Same here. https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261/comment/f4fd442f_72d7a... PS1, Line 328: lengthf := 2, Same here. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/34261 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: I3846d2a077e4bc53a772e354fcc3c38ca952b38f Gerrit-Change-Number: 34261 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-CC: fixeria <vyanitskiy@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Aug 2023 14:39:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment