Attention is currently required from: Hoernchen, fixeria, laforge, osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41660?usp=email )

Change subject: bts-trx: define TRXD_MSG_BUF_SIZE as a more realistic lower value ......................................................................

Patch Set 6:

(3 comments)

File src/osmo-bts-trx/trx_if.h:

https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/9020ceed_2aa3d083?usp=... : PS6, Line 7: NOTE: a legacy transceiver may append two garbage bytes.

This is only relevant for Uplink TRXDv0 PDUs, see my suggestion `a)` below.

Done

https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/5d865c29_703a6c1f?usp=... : PS6, Line 16: TRXD_UL_V2HDR_LEN

Note that size of optional TDMA Fn is not included here (it is also not included in the original `TR […]

Done

https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/150296cc_0e1ae961?usp=... : PS6, Line 17: TRXD_UL_V0HDR_LEN

Suggestion `a)`: `TRXD_UL_V0HDR_LEN + 2` to account for two garbage bytes. […]

Done