Attention is currently required from: Hoernchen, fixeria, laforge, osmith. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bts/+/41660?usp=email ) Change subject: bts-trx: define TRXD_MSG_BUF_SIZE as a more realistic lower value ...................................................................... Patch Set 6: (3 comments) File src/osmo-bts-trx/trx_if.h: https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/9020ceed_2aa3d083?usp=... : PS6, Line 7: NOTE: a legacy transceiver may append two garbage bytes.
This is only relevant for Uplink TRXDv0 PDUs, see my suggestion `a)` below. Done
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/5d865c29_703a6c1f?usp=... : PS6, Line 16: TRXD_UL_V2HDR_LEN
Note that size of optional TDMA Fn is not included here (it is also not included in the original `TR […] Done
https://gerrit.osmocom.org/c/osmo-bts/+/41660/comment/150296cc_0e1ae961?usp=... : PS6, Line 17: TRXD_UL_V0HDR_LEN
Suggestion `a)`: `TRXD_UL_V0HDR_LEN + 2` to account for two garbage bytes. […] Done
-- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/41660?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: Ic725e26637f8c116cfd5e64ff54d60a1d1bf9b87 Gerrit-Change-Number: 41660 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pespin@sysmocom.de> Gerrit-Reviewer: Hoernchen <ewild@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanitskiy@sysmocom.de> Gerrit-Reviewer: laforge <laforge@osmocom.org> Gerrit-Reviewer: osmith <osmith@sysmocom.de> Gerrit-Attention: osmith <osmith@sysmocom.de> Gerrit-Attention: Hoernchen <ewild@sysmocom.de> Gerrit-Attention: laforge <laforge@osmocom.org> Gerrit-Attention: fixeria <vyanitskiy@sysmocom.de> Gerrit-Comment-Date: Mon, 15 Dec 2025 11:23:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanitskiy@sysmocom.de>