Attention is currently required from: osmith.

pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-pcap/+/39944?usp=email )

Change subject: client: use osmo_stream_cli to transmit data to pcap-server ......................................................................

Patch Set 4:

(2 comments)

File src/osmo_client_network.c:

https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/fd8b15c5_f7e1aefe?usp... : PS4, Line 83: cannot never

• cannot never? […]

we can, for instance if msgb queue is full. This API lacking a return code is indeed a known issue I spotted a while ago, it may even have some ticket about it already.

I'll fix the comment as you said.

https://gerrit.osmocom.org/c/osmo-pcap/+/39944/comment/bc624691_4019e8e3?usp... : PS4, Line 137: int conn_cb(struct osmo_fd *fd, unsigned int what)

maybe also name it conn_cb_tls?

Acknowledged