Attention is currently required from: osmith.

View Change

2 comments:

• File src/osmo_client_network.c:

  • Patch Set #4, Line 83: cannot never

    * cannot never? […]

    we can, for instance if msgb queue is full.
    This API lacking a return code is indeed a known issue I spotted a while ago, it may even have some ticket about it already.

    I'll fix the comment as you said.

  • Patch Set #4, Line 137: int conn_cb(struct osmo_fd *fd, unsigned int what)

    maybe also name it conn_cb_tls?

    Acknowledged

To view, visit change 39944. To unsubscribe, or for help writing mail filters, visit settings.