Attention is currently required from: pespin.
fixeria has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-msc/+/39952?usp=email )
Change subject: SMS-over-GSUP: send network-originated MT-forwardSM-Err ......................................................................
Patch Set 1:
(2 comments)
File src/libmsc/gsm_04_11.c:
https://gerrit.osmocom.org/c/osmo-msc/+/39952/comment/16484084_7d99a05e?usp=... : PS1, Line 1332: rate_ctr_inc(rate_ctr_group_get_ctr(net->msc_ctrs, MSC_CTR_SMS_DELIVERED));
(as FIXME mentions, this is probably in the wrong place).
Wrong place for what? This FIXME is about incrementing a counter way too early. I don't see how this might be related to this patch.
https://gerrit.osmocom.org/c/osmo-msc/+/39952/comment/a33f2e12_4c1d7f99?usp=... : PS1, Line 1457: }
(we may want to add a rate counter for failed deliveries here. […]
Yeah, but I would prefer doing this in a separate patch.
-
fixeria