Attention is currently required from: pespin.

View Change

2 comments:

• File src/libmsc/gsm_04_11.c:

  • Patch Set #1, Line 1332: rate_ctr_inc(rate_ctr_group_get_ctr(net->msc_ctrs, MSC_CTR_SMS_DELIVERED));

    (as FIXME mentions, this is probably in the wrong place).

    Wrong place for what? This FIXME is about incrementing a counter way too early.
    I don't see how this might be related to this patch.

  • Patch Set #1, Line 1457: }

    (we may want to add a rate counter for failed deliveries here. […]

    Yeah, but I would prefer doing this in a separate patch.

To view, visit change 39952. To unsubscribe, or for help writing mail filters, visit settings.