Attention is currently required from: pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/34192 )

Change subject: pcuif_proto: check confirm flag in struct gsm_pcu_if_pch ......................................................................

Patch Set 4:

(2 comments)

File src/osmo-bsc/pcu_sock.c:

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/129ec082_9e79a90b PS2, Line 559: if (!pch->confirm)

I'm not really following. […]

In the current implementation we always include RSL_IE_ERIC_MOBILE_ID when sending the IMMEDIATE ASSIGNMENT COMMAND. I have checked some of my notes again and as far as I understand this is indeed an optional field. So if we want a confirmation from the BTS we include this field. If we don't want a confirmation, we just leave it away.

I quickly changed the implementation of abis_rsl:rsl_ericsson_imm_assign_cmd() so that we can select if we want a confirmation or not.

This also means that we now have the same behavior as we have in osmo-bts.

https://gerrit.osmocom.org/c/osmo-bsc/+/34192/comment/fc9dbcc5_ba227a61 PS2, Line 566: if (pch->confirm)

Just send the confirmation when you transmit the related block over RSL. […]

Ok, I added this. So in that regard the behavior is now (almost) exactly like the one of osmo-bts.