Attention is currently required from: pespin.

View Change

2 comments:

• File src/osmo-bsc/pcu_sock.c:

  • Patch Set #2, Line 559: if (!pch->confirm)

    I'm not really following. […]

    In the current implementation we always include RSL_IE_ERIC_MOBILE_ID when sending the IMMEDIATE ASSIGNMENT COMMAND. I have checked some of my notes again and as far as I understand this is indeed an optional field. So if we want a confirmation from the BTS we include this field. If we don't want a confirmation, we just leave it away.

    I quickly changed the implementation of abis_rsl:rsl_ericsson_imm_assign_cmd() so that we can select if we want a confirmation or not.

    This also means that we now have the same behavior as we have in osmo-bts.

  • Patch Set #2, Line 566: if (pch->confirm)

    Just send the confirmation when you transmit the related block over RSL. […]

    Ok, I added this. So in that regard the behavior is now (almost) exactly like the one of osmo-bts.

To view, visit change 34192. To unsubscribe, or for help writing mail filters, visit settings.