Attention is currently required from: osmith, laforge, fixeria, daniel.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-bts/+/30689
)
Change subject: shutdown_fsm: Add power_ramp_force() to jump straight to the tgt power
......................................................................
Patch Set 2:
(1 comment)
File include/osmo-bts/tx_power.h:
https://gerrit.osmocom.org/c/osmo-bts/+/30689/comment/481aee21_06b3e397
PS2, Line 83: force
Maybe '_skip' is a better fit here?
it's not actually skipping it, it's just doing it in one step. Force is more
meaningful than "start" here. Maybe "start_direct" would be better,
but not that important IMHO.
--
To view, visit
https://gerrit.osmocom.org/c/osmo-bts/+/30689
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Ida1d7bbf094958b9142af306dbf84206729a609e
Gerrit-Change-Number: 30689
Gerrit-PatchSet: 2
Gerrit-Owner: daniel <dwillmann(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Reviewer: laforge <laforge(a)osmocom.org>
Gerrit-Reviewer: osmith <osmith(a)sysmocom.de>
Gerrit-Reviewer: pespin <pespin(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: laforge <laforge(a)osmocom.org>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: daniel <dwillmann(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 20:17:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment