Attention is currently required from: fixeria.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/libosmo-netif/+/30756 )
Change subject: amr: osmo_amr_bwe_to_oa(): validate input data is long enough
......................................................................
Patch Set 1:
(1 comment)
File src/amr.c:
https://gerrit.osmocom.org/c/libosmo-netif/+/30756/comment/77dcbc9a_8ae34f6c
PS1, Line 224: 10
Can you please explain where 10 comes from? […]
It's the header size of amr_bwe_hdr in bits.
The first 10 bits it's header, which leaves 6 bits for data to fill the 2nd octet.
--
To view, visit
https://gerrit.osmocom.org/c/libosmo-netif/+/30756
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Change-Id: I2d11ce71c29ae046c2feab1e59045d97dc3e5099
Gerrit-Change-Number: 30756
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Attention: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-Comment-Date: Wed, 21 Dec 2022 20:16:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: fixeria <vyanitskiy(a)sysmocom.de>
Gerrit-MessageType: comment