Attention is currently required from: pespin.

dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34058 )

Change subject: pcu_l1_if: add support for PCU_IF_SAPI_AGCH_2 for PCUIF v.11 ......................................................................

Patch Set 3:

(3 comments)

File src/bts.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/0d7b0b0a_a76b790e PS2, Line 1037: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false);

if we don't need cofnirmation so far, we don't need to pass a msg_id based on TLLI which may be actu […]

Done

https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/3bf7f9bb_1064d4cd PS2, Line 1055: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false);

Same, TLLI_UNUSED

Done

File src/pcu_l1_if.cpp:

https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/c4195060_053f4bc9 PS2, Line 278: /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX

why did you drop this comment? This all still holds true afaict if v10 is being used.

I thought I could remove it since we use pcu_l1if_tx_agch2() in case no IMSI is present. But yes, the problem is still there in v.10.