Attention is currently required from: pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/34058 ) Change subject: pcu_l1_if: add support for PCU_IF_SAPI_AGCH_2 for PCUIF v.11 ...................................................................... Patch Set 3: (3 comments) File src/bts.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/0d7b0b0a_a76b790e PS2, Line 1037: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false);
if we don't need cofnirmation so far, we don't need to pass a msg_id based on TLLI which may be actu […] Done
https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/3bf7f9bb_1064d4cd PS2, Line 1055: pcu_l1if_tx_agch2(bts, bv, plen, tbf->tlli(), false);
Same, TLLI_UNUSED Done
File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/c/osmo-pcu/+/34058/comment/c4195060_053f4bc9 PS2, Line 278: /* OS#6097: if strlen(imsi) == 0: We assume the MS is in non-DRX
why did you drop this comment? This all still holds true afaict if v10 is being used. I thought I could remove it since we use pcu_l1if_tx_agch2() in case no IMSI is present. But yes, the problem is still there in v.10.
-- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/34058 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I9effdcec1da91a6e2e7a7c41f95d3300ad1bb292 Gerrit-Change-Number: 34058 Gerrit-PatchSet: 3 Gerrit-Owner: dexter <pmaier@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pespin@sysmocom.de> Gerrit-Attention: pespin <pespin@sysmocom.de> Gerrit-Comment-Date: Tue, 29 Aug 2023 10:39:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pespin@sysmocom.de> Gerrit-MessageType: comment