Attention is currently required from: daniel, laforge, neels, pespin.

lynxis lazus has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-msc/+/38490?usp=email )

Change subject: vlr: add PS support ......................................................................

Patch Set 6:

(5 comments)

File src/libvlr/vlr_lu_fsm.c:

https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ce929dee_04b1d31b?usp=... : PS5, Line 587: return 1;

Agree

Done

https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/2d4161d8_74395881?usp=... : PS5, Line 598: break;

yeah makes sense having an ASSERT which should hit indicating some timeout was forgotten to be added […]

Done

https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/f88cac26_765b45a5?usp=... : PS5, Line 1570: {

(would be nice to have a short one-liner comment to indicate what this does / why it needs to go in […]

I replaced the preterm and moved it into the timer_cb.

https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/9fa5cb4d_a97ea383?usp=... : PS5, Line 1586: gsm48_cause = GSM48_REJECT_NETWORK_FAILURE;

(add "break;" in the end)

Done

https://gerrit.osmocom.org/c/osmo-msc/+/38490/comment/ea27908f_124cd4d0?usp=... : PS5, Line 1742:

(two blank lines, unusual for osmocom)

Done