Attention is currently required from: daniel, laforge, neels, pespin.

View Change

5 comments:

• File src/libvlr/vlr_lu_fsm.c:

  • Patch Set #5, Line 587: return 1;

    Agree

    Done

  • Patch Set #5, Line 598: break;

    yeah makes sense having an ASSERT which should hit indicating some timeout was forgotten to be added […]

    Done

  • Patch Set #5, Line 1570: {

    (would be nice to have a short one-liner comment to indicate what this does / why it needs to go in […]

    I replaced the preterm and moved it into the timer_cb.

  • Patch Set #5, Line 1586: gsm48_cause = GSM48_REJECT_NETWORK_FAILURE;

    (add "break;" in the end)

    Done

  • Patch Set #5, Line 1742:

    (two blank lines, unusual for osmocom)

    Done

To view, visit change 38490. To unsubscribe, or for help writing mail filters, visit settings.