Attention is currently required from: laforge, fixeria. msuraev has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/29170 )

Change subject: SIGTRAN: add osmo_sccp_tx_disconn_data() helper ......................................................................

Patch Set 3:

(4 comments)

File examples/sccp_test_vty.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/3246d21f_86c3c4d5 PS1, Line 97:

I would expect it to be aligned to the opening brace, and it looks like you intended to do so. […]

Done

File examples/sccp_test_vty.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/02318179_c4a28f71 PS2, Line 97: [DATA]

You forgot to add documentation an optional parameter: […]

Done

https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/f0e77100_09142d00 PS2, Line 103: argv[1]

Is argv[1] guaranteed to be NULL if argc < 2? There might be garbage left in the argv[] buffer, so I […]

Indeed. Actually, I think it's better to skip the data variable altogether - see next revision.

I don't see any use for hex input: so far only the presence of data and the amount of it were important for testing - actual content was irrelevant.

File include/osmocom/sigtran/sccp_helpers.h:

https://gerrit.osmocom.org/c/libosmo-sccp/+/29170/comment/0b2c5208_cd72b691 PS2, Line 48:

Really weird alignment making it rather harder to read. Tab-size should be 8.

Done