Attention is currently required from: jolly, pespin.

fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/34476?usp=email )

Change subject: ASCI: Add GCC/BCC (call control) to mobility management ......................................................................

Patch Set 3: Code-Review+1

(3 comments)

File src/host/layer23/src/mobile/gsm48_mm.c:

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/685030a0_381ee7bd PS3, Line 4096: mm_conn_new_ref++);

wrong indentation. You can actually put it in the same line.

Ack

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/4141f0cc_ea787dc5 PS3, Line 4114: || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) {

wrong indentation. […]

I would be more careful when saying "wrong". There is nothing wrong with it, it's simply different from what you prefer. This "wrong" variant looks good to me and I think I also used it in some places. `gits do grep` shows me plenty of examples with this kind of formatting.

https://gerrit.osmocom.org/c/osmocom-bb/+/34476/comment/3d374985_ef82f348 PS3, Line 4153: rc = -ENOTSUP Is setting `rc` really needed here? Can't we just do `return -ENOTSUP` below?