Attention is currently required from: jolly, pespin.

Patch set 3:Code-Review +1

View Change

3 comments:

• File src/host/layer23/src/mobile/gsm48_mm.c:

  • Patch Set #3, Line 4096: mm_conn_new_ref++);

    wrong indentation. You can actually put it in the same line.

    Ack

  • Patch Set #3, Line 4114: || mm->state == GSM48_MM_ST_RR_CONN_RELEASE_NA) {

    wrong indentation. […]

    I would be more careful when saying "wrong". There is nothing wrong with it, it's simply different from what you prefer. This "wrong" variant looks good to me and I think I also used it in some places. `gits do grep` shows me plenty of examples with this kind of formatting.

  • Patch Set #3, Line 4153: rc = -ENOTSUP

    Is setting `rc` really needed here? Can't we just do `return -ENOTSUP` below?

To view, visit change 34476. To unsubscribe, or for help writing mail filters, visit settings.