[M] Change in osmo-pcu[master]: Re-store last LLC frames never completely acked when freeing DL TBF - gerrit-log

29 Jun 2023


      Attention is currently required from: pespin.
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/33525 )
Change subject: Re-store last LLC frames never completely acked when freeing DL TBF
......................................................................
Patch Set 2:
(2 comments)
File src/llc.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/ebcb53ad_a47e31eb 
PS2, Line 368: 		OSMO_ASSERT(info);
...
If the queue is empty, msg=NULL and return in line 362 occurs, so this case you say cannot happen.
Ack
File src/tbf_dl.cpp:
https://gerrit.osmocom.org/c/osmo-pcu/+/33525/comment/b72bb0eb_c8abb27d 
PS2, Line 546: if any
...
See my other comment, function doesn't assert.
Ack
-- 
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/33525
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I9be4035fb2cf2b3ee56e91dcc12cc8c24028b4aa
Gerrit-Change-Number: 33525
Gerrit-PatchSet: 2
Gerrit-Owner: pespin pespin@sysmocom.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith osmith@sysmocom.de
Gerrit-Attention: pespin pespin@sysmocom.de
Gerrit-Comment-Date: Thu, 29 Jun 2023 12:53:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith osmith@sysmocom.de
Comment-In-Reply-To: pespin pespin@sysmocom.de
Gerrit-MessageType: comment