Attention is currently required from: osmith.
pespin has posted comments on this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/33530
)
Change subject: tbf_dl_fsm: Fix '{FLOW}: Event ASSIGN_PCUIF_CNF not permitted'
......................................................................
Patch Set 2:
(1 comment)
File src/tbf_dl_fsm.c:
https://gerrit.osmocom.org/c/osmo-pcu/+/33530/comment/40a1d2c3_11086416
PS2, Line 227: "(CCCH was not requested on current assignment)\n");
This sounds like it will not be ignored if CCCH is in
state_flags, but it is also ignoring it there […]
Yes, it's intentional. We
ignore it because it's from a previous assignment, but it won't trigger the alarms
of a user looking at the code or logging of running osmo-pcu since it will be an expected
event (receiving PCUIF_CNF if it was assigned over CCCH).
--
To view, visit
https://gerrit.osmocom.org/c/osmo-pcu/+/33530
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I042b0117552acae25c750e762f5cc254399da64f
Gerrit-Change-Number: 33530
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pespin(a)sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: osmith <osmith(a)sysmocom.de>
Gerrit-Attention: osmith <osmith(a)sysmocom.de>
Gerrit-Comment-Date: Thu, 29 Jun 2023 12:55:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osmith(a)sysmocom.de>
Gerrit-MessageType: comment