Attention is currently required from: msuraev. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/31295 )
Change subject: SS7: do not attempt transfer if AS is down ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File src/osmo_ss7_hmrt.c:
https://gerrit.osmocom.org/c/libosmo-sccp/+/31295/comment/7e7cfb15_839e3ed6 PS1, Line 232: LOGP(DLSS7, LOGL_ERROR, "The AS %s is down\n", as->cfg.name); I think the log line could benefit from some context like "canout route" or "cannot send packet" or whatever. For a debug message like above/below, I think it's fine. but for an error message intended for the "casual" user, I think it's best to be more descriptive about why we're logging the message "AS is down" right now.